Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never run in delegate method #29

Closed
mjspawn opened this issue Aug 23, 2013 · 3 comments
Closed

Never run in delegate method #29

mjspawn opened this issue Aug 23, 2013 · 3 comments

Comments

@mjspawn
Copy link

mjspawn commented Aug 23, 2013

in MPNotificationView.m

at handleTap()

if (_tapBlock != nil)
{
_tapBlock(self);
}

if ([_delegate respondsToSelector:@selector(tapReceivedForNotificationView:)])
{
    [_delegate didTapOnNotificationView:self];
}

[[NSNotificationCenter defaultCenter] postNotificationName:kMPNotificationViewTapReceivedNotification
                                                    object:self];

change to

if (_tapBlock != nil)
{
_tapBlock(self);
} else if ([_delegate respondsToSelector:@selector(didTapOnNotificationView:)])
{
[_delegate didTapOnNotificationView:self];
} else
{
[[NSNotificationCenter defaultCenter] postNotificationName:kMPNotificationViewTapReceivedNotification
object:self];
}

@benkax
Copy link

benkax commented Aug 1, 2014

yes, same problem here, if ([_delegate respondsToSelector:@selector(tapReceivedForNotificationView:)]) will never be true, any fix already?

@mjspawn
Copy link
Author

mjspawn commented Aug 1, 2014

why always post notification?

@ekurutepe
Copy link
Owner

Why not?

Sent from my iPhone

On 01.08.2014, at 11:46, mjspawn notifications@github.com wrote:

why always post notification?


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants