Fix Windows cargo test #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekzhang
reviewed
Apr 20, 2022
| @@ -84,7 +84,7 @@ impl Server { | |||
| return Ok(()); | |||
| } | |||
| info!(?port, "new client"); | |||
| let listener = match TcpListener::bind(("::", port)).await { | |||
| let listener = match TcpListener::bind(("0.0.0.0", port)).await { | |||
There was a problem hiding this comment.
Does this work even when "::" or Ipv6Addr::UNSPECIFIED is passed in? I wanted to make sure that the server was listening on both Ipv4 and Ipv6 in dual-stack mode.
There was a problem hiding this comment.
It does not with both. That is why I changed it. At least from my testing ipv6 does no work even before that change but can be my network setup
There was a problem hiding this comment.
Got it, thanks for looking into this and figuring out the issue!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says the changes are fixing cargo test on Windows.
I tested it on VM and with CI config from #10 and you can see here that it's working fine