Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new similarity function: containment_max #2

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Conversation

ardate
Copy link
Contributor

@ardate ardate commented Feb 20, 2019

Based on our communication via e-mail, I am adding a new similarity function "containment_max". This similarity function is similar to "containment", with the difference that the similarity value between two sets is normalised by the max. length of the two sets (instead of normalising it by the length of set1 as in "containment" function).

@ekzhu
Copy link
Owner

ekzhu commented Mar 21, 2019

Thanks! Sorry for the delay. This seems to be better called "containment min", because it would be the minimum of two containment scores |x \cap y| / |x| and |x \cap y| / |y|. "containment max" would be dividing by min(|x|, |y|).

@ardate
Copy link
Contributor Author

ardate commented Mar 22, 2019 via email

@ekzhu ekzhu merged commit 429e6f8 into ekzhu:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants