Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow aioMongo config to set DSN and Collection Name directly #123

Closed
EliseAv opened this issue Mar 5, 2020 · 2 comments
Closed

Allow aioMongo config to set DSN and Collection Name directly #123

EliseAv opened this issue Mar 5, 2020 · 2 comments

Comments

@EliseAv
Copy link
Contributor

EliseAv commented Mar 5, 2020

I use Mongo Atlas, and, as such, my database connection string starts with mongodb+srv://. None of the currently supported options in experimental/aio/storage.py currently support that.

Additionally, I noticed that the collection name is a very opaque four-character prefix and a random string. I need to be able to modify that as well, if only at least the prefix.

I'm open to creating a Pull-Request to fix that, and I might just start doing this tomorrow, but I'd like to open the issue first.
@ekzhu
Copy link
Owner

ekzhu commented Mar 5, 2020

@aastafiev

Cool sounds good!

EliseAv added a commit to EliseAv/datasketch that referenced this issue Mar 6, 2020
@EliseAv
Issue ekzhu#123 arbitrary Mongo URL & collection name
7652e5a
ekzhu added a commit that referenced this issue Mar 12, 2020
@ekzhu
Implement #123 arbitrary Mongo URL & collection name (#124)
e5f14ae 
* Issue #123 arbitrary Mongo URL & collection name

* #124 updated unit tests

* update doc

Co-authored-by: ekzhu <ekzhu@users.noreply.github.com>
@ekzhu
Copy link
Owner

ekzhu commented Mar 17, 2020

@ekevoo Thank you for your contribution! I am closing this issue now.

@ekzhu ekzhu closed this as completed Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ekzhu @EliseAv