dynamic loader: Introduce use of nv-codec-headers #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This requires philipl/nv-codec-headers@4d38030 which I will get merged. |
|
Thanks for this. The patch looks fine. I'll wait for you to get that nv-codec-headers change merged in. |
|
Change is merged at https://git.videolan.org/?p=ffmpeg/nv-codec-headers.git;a=commit;h=50d5add953977a2050a7b7e569b0ff4df1a1ce3e So, this change is now good to go. |
pobrn
reviewed
Jan 10, 2022
nv-codec-headers provides a dynamic symbol loader that makes it much easier to build cuda/nvdec/nvenc dependent code and it's used by ffmpeg and mpv. This driver makes heavy use of cuda and nvdec, and so it too can benefit from having a dynamic loader to avoid requiring the cuda SDK at build time. I had to introduce the EGLStream related symbols and data types into nv-codec-headers, but with those in place, it's a simple mechanical process to switch over. Fixes elFarto#1.
|
I believe
errors. |
|
Interesting, I'm not seeing those and it's working fine and it's not linked with libdl. |
|
I think in some configurations, varying by distro and compiler, you may need to explicitly include |
|
Ok, added. @pobrn Let me know if that fixes it. |
|
It builds now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nv-codec-headers provides a dynamic symbol loader that makes it much
easier to build cuda/nvdec/nvenc dependent code and it's used by ffmpeg
and mpv. This driver makes heavy use of cuda and nvdec, and so it too
can benefit from having a dynamic loader to avoid requiring the cuda
SDK at build time.
I had to introduce the EGLStream related symbols and data types into
nv-codec-headers, but with those in place, it's a simple mechanical
process to switch over.
Fixes #1.