Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect e-Mail Address on System Mail Responses #552

Closed
chlarsen opened this issue Dec 11, 2017 · 4 comments
Closed

Incorrect e-Mail Address on System Mail Responses #552

chlarsen opened this issue Dec 11, 2017 · 4 comments
Labels
bug

Comments

@chlarsen
Copy link

chlarsen commented Dec 11, 2017 •
edited

Description of the problem

Greetings from Malawi,
I noted that the eLabFTW provides the domain without sub-folder (where eLabFTW is happily running) in its mail responses.
Example: I run eLabFTW in https://www.[my.domain]/elabftw/ without issues.
Registrants endorsed by the team admin get a mail saying:

[eLabFTW] Account validated
Hello. Your account on eLabFTW was validated by an admin. Follow this link to login: https://www.[my.domain]/login.php

~~~
Sent from eLabFTW https://www.elabftw.net

Also the sent from address in the text is not right, but that might be me not setting up a template properly. Any thoughts?
Thank you!
Chris

DO NOT DELETE THE TEXT BELOW
BUT FILL THE REQUESTED INFOS!!!!!!

Informations

  • Elabftw version (visible in Sysadmin panel) : 1.7.7
  • Installation method (git, docker or zip archive) : git
  • Operating system + version : FreeBSD 10.4-RELEASE-p3
  • Browser used (firefox/chrome) : Firefox 52.5.2

For git/zip installation method:

  • PHP version: PHP 7.0.26 with Zend Engine v3.0.0, deployed as php-fpm
  • MySQL version: MariaDB 10.1.29
  • Webserver (apache/nginx) + version : Nginx 1.13.7 with FastCGI
@chlarsen chlarsen changed the title Incorrect e-Mail Incorrect e-Mail Address on System Mail Responses Dec 11, 2017
@NicolasCARPi
Copy link
Contributor

Hello,

Yes, I can see how this bug might happen (related to the previous one you reported). Will try and fix it before release of 1.8.0.

@chlarsen
Copy link
Author

chlarsen commented Dec 12, 2017 via email

NicolasCARPi added a commit that referenced this issue Dec 13, 2017
@NicolasCARPi
better url generation to cover subfolder case. fix #552
9d3c711 
still perfectible though…
@NicolasCARPi
Copy link
Contributor

Fixed!

@chlarsen
Copy link
Author

Terrific, thank you!

NicolasCARPi added a commit that referenced this issue Dec 14, 2017
@NicolasCARPi
Merge branch 'hypernext' into demo
90c6deb 
* hypernext: (113 commits)
  fix some signature mismatches
  use documented order of parameters for implode()
  Fix display of long tables (bug #532) (#553)
  better url generation to cover subfolder case. fix #552
  fix multiple id on edituser new password field
  ran grunt
  add button to replace existing upload. fix #501
  fix incorrect redirection on subfolder installs. fix #549
  fix notice in metadata.php
  remove unused property
  fix categoryArr in database
  fix undec var in view.js
  fix some anon user notices
  fix comments update
  fix some undeclared vars in edit.js
  only show top right search bar on experiments or database pages
  remove bad composer.lock
  fix the display of comments. fix #546
  composer update
  fix show.js
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chlarsen @NicolasCARPi