Fix bug when no name was configured #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mail contained "Hello undefined"
|
Thanks so much for your contribution @maryum375! 😄 LGTM. Next time, please format your code according to the project's code style. 👍 |
eladnava
added a commit
that referenced
this pull request
Sep 6, 2016
Refactor code from #15. Thanks to @maryum375 for the PR.
|
Released v1.0.26 @maryum375 |
| @@ -113,7 +113,11 @@ Mailgen.prototype.parseParams = function (params) { | |||
|
|
|||
| // Use `greeting` and `name` for title if not set | |||
| if (!body.title) { | |||
| body.title = body.greeting + ' ' + body.name + ','; | |||
| body.title = body.greeting; | |||
There was a problem hiding this comment.
Can't the same thing happen with body.greeting being undefined?
There was a problem hiding this comment.
Ahh cool, didn't open the entire file to look it up.
Good job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mail contained "Hello undefined"