Fixed a bug when a nested dataclass had required arguments 🐛

eladrich · Jan 6, 2022 · bcd2a70 · bcd2a70
1 parent ffc1c0d
commit bcd2a70
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/pyrallis/__init__.py b/pyrallis/__init__.py
@@ -1,4 +1,4 @@
-__version__ = "0.1.4.1"
+__version__ = "0.1.4.2"
 
 from . import wrappers, utils
 from pyrallis.help_formatter import SimpleHelpFormatter

diff --git a/pyrallis/wrappers/dataclass_wrapper.py b/pyrallis/wrappers/dataclass_wrapper.py
@@ -130,8 +130,14 @@ def defaults(self) -> List[Dataclass]:
                     default = getattr(default, self.name)
                 self._defaults.append(default)
         else:
-            default_field_value = utils.default_value(
-                self._field)  # NOTE: That's my problem, post_init was called here to create defaults, understand when defaults are used
+            try:
+                default_field_value = utils.default_value(self._field)
+            except TypeError as e:
+                # utils.default_value tries to construct the field to get default value and might fail
+                # if the field has some required arguments
+                logger.debug(
+                    f"Could not get default value for field '{self._field.name}'\n\tUnderlying Error: {e}")
+                default_field_value = dataclasses.MISSING
             if isinstance(default_field_value, _MISSING_TYPE):
                 self._defaults = []
             else: