Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-manifold input to SimplifyTopology in Boolean.Close test #176

Closed
elalish opened this issue Aug 4, 2022 · 0 comments · Fixed by #179
Closed

Non-manifold input to SimplifyTopology in Boolean.Close test #176

elalish opened this issue Aug 4, 2022 · 0 comments · Fixed by #179
Assignees

Comments

@elalish
Copy link
Owner

elalish commented Aug 4, 2022

First noticed in #171, but subsequently the same failure was found on master when running CUDA. The infinite loop is a byproduct of the mesh not being manifold. Technically IsManifold() checks two different things: first, is the data structure sane, and second are there any duplicated edges (which make it not a 2-manifold - two triangles attached to every edge). SimplifyTopology is designed to fix meshes that are not 2-manifold into ones that are 2-manifold. However, we should not be producing any intermediate mesh that isn't sane. I need to add an assert about this to make these problems easier to spot (this is the second time I've run into something like this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant