Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176
In pairing halfedges to construct the manifold, in the case of a duplicate edge (not a 2-manifold, which is occasionally caused by the triangulation), it was possible that I would pair the two forward edges together and the two backward edges together, which doesn't work. Now I've adjusted the way I sort to ensure I always pair a forward edge with a backward edge.
I've also separated the internal
IsManifold
check into two:IsManifold
now only checks for data structure sanity (the problem we had here, and something that should be true at every step of the algorithm), while the newIs2Manifold
also checks for edge duplication. The publicIsManifold
's behavior is unchanged. I've added asserts forIsManifold
to catch this kind of problem in the future more quickly, but they only get triggered in verbose mode.