Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows compatibility #111

Merged
merged 7 commits into from
May 12, 2022
Merged

windows compatibility #111

merged 7 commits into from
May 12, 2022

Conversation

pca006132
Copy link
Collaborator

Tries fixing windows build error. It seems that msvc doesn't really like alternative tokens and getopt.

It seems that msvc does not like alternatife operators and getopt.
@pca006132
Copy link
Collaborator Author

Well... at least it now builds. Not sure what is that error message when trying to run the manifold_test.exe.

Copy link
Owner

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that error is quite inscrutable. What compiler is it using? It sort of seems like that should be specified in the yml file somewhere, though I suppose the machine has a default?

printf("manifold_test specific options:\n");
printf(" -h: Print this message\n");
printf(" -e: Export sample models\n");
printf(" -v: Enable verbose output\n");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -69,7 +69,7 @@ struct is_unordered_map<
template <typename T>
constexpr bool is_unordered_map_v = is_unordered_map<T>::value;
template <typename T>
constexpr bool is_either_map_v = is_map_v<T> or is_unordered_map_v<T>;
constexpr bool is_either_map_v = is_map_v<T> || is_unordered_map_v<T>;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was considering making this a submodule, but maybe we should leave it as is so we can make these fixes...

.github/workflows/manifold.yml Outdated Show resolved Hide resolved
@elalish
Copy link
Owner

elalish commented May 12, 2022

It almost looks like it's printing the environment info, but not the actual std::out. I wonder if there's some flag necessary to get the actual console output? Google_test doesn't generally error out without printing at least something.

@pca006132
Copy link
Collaborator Author

It is using msvc, installed with ilammy/msvc-dev-cmd@v1. The error is very interesting because I tried building it on my windows laptop and it successfully builds and run the tests previously, perhaps some issue with c++ runtime or something? Quite hard to debug this as the CI is pretty much a blackbox to me...

@pca006132
Copy link
Collaborator Author

Wondering if we should disable /Wall (-Wall for msvc) considering msvc is emitting so many warnings...

@pca006132
Copy link
Collaborator Author

Test passed for the CPP backend on Windows. For some reason the CUDA backend compilation will just exit without any error messages making it nearly impossible to debug, so I just disabled the CUDA build on it for now.

Added support for building with Nix, which allows us to pin the version of each dependencies (nodejs, emscripten, openmp, g++, etc.), hopefully this can make debugging CI failures on Linux a bit less painful as we can reproduce this locally.

Copy link
Owner

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks!

steps:
- uses: actions/checkout@v2.4.0
- uses: cachix/install-nix-action@v15
- run: nix build -L '.?submodules=1#manifold-${{matrix.variant}}'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I hadn't heard of nix before, but reading about it I already like it.

@elalish elalish merged commit fadad77 into elalish:master May 12, 2022
@pca006132 pca006132 deleted the windows branch December 22, 2022 05:35
cartesian-theatrics pushed a commit to SovereignShop/manifold that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants