-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows compatibility #111
Conversation
It seems that msvc does not like alternatife operators and getopt.
Well... at least it now builds. Not sure what is that error message when trying to run the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that error is quite inscrutable. What compiler is it using? It sort of seems like that should be specified in the yml file somewhere, though I suppose the machine has a default?
printf("manifold_test specific options:\n"); | ||
printf(" -h: Print this message\n"); | ||
printf(" -e: Export sample models\n"); | ||
printf(" -v: Enable verbose output\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -69,7 +69,7 @@ struct is_unordered_map< | |||
template <typename T> | |||
constexpr bool is_unordered_map_v = is_unordered_map<T>::value; | |||
template <typename T> | |||
constexpr bool is_either_map_v = is_map_v<T> or is_unordered_map_v<T>; | |||
constexpr bool is_either_map_v = is_map_v<T> || is_unordered_map_v<T>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was considering making this a submodule, but maybe we should leave it as is so we can make these fixes...
It almost looks like it's printing the environment info, but not the actual |
It is using msvc, installed with |
Wondering if we should disable |
Test passed for the CPP backend on Windows. For some reason the CUDA backend compilation will just exit without any error messages making it nearly impossible to debug, so I just disabled the CUDA build on it for now. Added support for building with Nix, which allows us to pin the version of each dependencies (nodejs, emscripten, openmp, g++, etc.), hopefully this can make debugging CI failures on Linux a bit less painful as we can reproduce this locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, thanks!
steps: | ||
- uses: actions/checkout@v2.4.0 | ||
- uses: cachix/install-nix-action@v15 | ||
- run: nix build -L '.?submodules=1#manifold-${{matrix.variant}}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I hadn't heard of nix before, but reading about it I already like it.
windows compatibility
Tries fixing windows build error. It seems that msvc doesn't really like alternative tokens and getopt.