-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize Directories #157
Conversation
@pca006132 I mostly got the CMake stuff fixed, but I'm having trouble building Assimp (it can't seem to find the paths it wants). Since you got a lot of that working, would you mind taking a look? |
diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
index 00048bc..070ccd8 100644
--- a/test/CMakeLists.txt
+++ b/test/CMakeLists.txt
@@ -5,7 +5,7 @@ add_subdirectory(meshIO)
enable_testing()
-file(GLOB_RECURSE SOURCE_FILES CONFIGURE_DEPENDS *.cpp)
+set(SOURCE_FILES mesh_test.cpp polygon_test.cpp samples_test.cpp test_main.cpp)
add_executable(${PROJECT_NAME} ${SOURCE_FILES})
target_link_libraries(${PROJECT_NAME} polygon GTest::GTest manifold meshIO samples) The old one will recursively include all code in assimp and google_test, and tries to compile them with our compilation options (which does not work). |
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
==========================================
+ Coverage 93.81% 94.01% +0.19%
==========================================
Files 32 30 -2
Lines 2861 2789 -72
==========================================
- Hits 2684 2622 -62
+ Misses 177 167 -10
Continue to review full report at Codecov.
|
Thanks for the pointer @pca006132! I decided to keep |
Nevermind, I switched to a github action for format checking; simpler and it's working. |
Reorganize Directories
Replacing #156; see commentary there. The idea is to make the project's structure more clear by changing from our current layout:
To this: