Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed triangulation bug #180

Merged
merged 1 commit into from
Aug 7, 2022
Merged

fixed triangulation bug #180

merged 1 commit into from
Aug 7, 2022

Conversation

elalish
Copy link
Owner

@elalish elalish commented Aug 7, 2022

I extracted the problem polygon from #171, made a test and fixed it. Also did a little cleanup and ensuring the early geometric checks are being performed properly in debug mode.

In the process I found another bug, which I added a disabled test for so I can deal with it in the next PR. It comes up in Sponge4 with #171, but not on master, so figured I'd go ahead and merge this first. Again, this is a legit triangulation failure, not a problem with #171.

@elalish elalish self-assigned this Aug 7, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #180 (a37b060) into master (a08a9e7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #180   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files          30       30           
  Lines        2630     2631    +1     
=======================================
+ Hits         2540     2541    +1     
  Misses         90       90           
Impacted Files Coverage Δ
src/manifold/src/manifold.cpp 89.65% <ø> (ø)
src/polygon/src/polygon.cpp 98.51% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@elalish elalish merged commit ae19d08 into master Aug 7, 2022
@elalish elalish deleted the extraTri branch August 7, 2022 19:07
@elalish elalish mentioned this pull request Aug 8, 2022
cartesian-theatrics pushed a commit to SovereignShop/manifold that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants