Add new MeshGL accessors (replacing MeshRelation) #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
elalish
approved these changes
Jan 28, 2023
elalish
added a commit
that referenced
this pull request
Jan 28, 2023
* removed BufferGeometryUtils * replaced three.js with gltf-transform * textured sphere working * added cubeUV * added textures * added relation and sorting to MeshGL * working textures example! * added faceID * removed MeshRelation * some more removal * fix output for no properties * test cleanup * Add new MeshGL accessors (replacing MeshRelation) (#311) + new meshgl accessors + remove mesh_relation_size * removed meshID from public API * added input checking for MeshGL * remove C api --------- Co-authored-by: Geoff deRosenroll <geoffderosenroll@gmail.com>
cartesian-theatrics
pushed a commit
to SovereignShop/manifold
that referenced
this pull request
Mar 11, 2024
* removed BufferGeometryUtils * replaced three.js with gltf-transform * textured sphere working * added cubeUV * added textures * added relation and sorting to MeshGL * working textures example! * added faceID * removed MeshRelation * some more removal * fix output for no properties * test cleanup * Add new MeshGL accessors (replacing MeshRelation) (elalish#311) + new meshgl accessors + remove mesh_relation_size * removed meshID from public API * added input checking for MeshGL * remove C api --------- Co-authored-by: Geoff deRosenroll <geoffderosenroll@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there anything I'm new that should be exposed that I'm missing here?