clean up editor.d.ts #348
Merged
clean up editor.d.ts #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #348 +/- ##
=======================================
Coverage 91.52% 91.52%
=======================================
Files 32 32
Lines 3730 3730
=======================================
Hits 3414 3414
Misses 316 316 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Oh wow, I'm surprised this works, and it's much cleaner than before. I thought it wouldn't work because concatenating the type definition files doesn't encapsulate the types, but you don't actually want to encapsulate them, since you can directly call functions like |
cartesian-theatrics
pushed a commit
to SovereignShop/manifold
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the ugly solution from #344, using the refactor from #347. FYI @rafern.