-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parallelize some csg operations #381
Conversation
Btw @elalish part of the compose function has to be executed sequentially and will cause segfault when parallelized (the for loop that I left), not sure if that is a bug. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #381 +/- ##
==========================================
+ Coverage 85.48% 85.96% +0.48%
==========================================
Files 36 36
Lines 4415 4468 +53
==========================================
+ Hits 3774 3841 +67
+ Misses 641 627 -14
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* parallelize some csg operations * use lower_bound on sorted vector
Just some trivial parallelization, results in ~5% improvement for meshes with many unions. Just thought of this and this makes me unable to fall asleep...
BatchBoolean
is not optimized yet, not sure if I should do parallelization as it will mess up with the mesh size and may end up being slower.