added global coplanarity check #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also added a test that catches this problem, and in the process noticed that I wasn't passing |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #408 +/- ##
==========================================
+ Coverage 86.02% 86.08% +0.06%
==========================================
Files 38 38
Lines 4580 4601 +21
==========================================
+ Hits 3940 3961 +21
Misses 640 640
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
pca006132
approved these changes
Apr 12, 2023
Merged
cartesian-theatrics
pushed a commit
to SovereignShop/manifold
that referenced
this pull request
Mar 11, 2024
* added global coplanarity check * fix early-out * added test, fixed precision * one more precision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #388
Planar faces are determined by testing neighboring triangles for coplanarity and then doing connected components on the result. The problem is little changes can add up: a finely tessellated sphere can potentially have every edge be coplanar within tolerance, resulting in a single huge planar face, which is obviously incorrect. This affects output
faceID, but also the internal edge collapsing and can result in wildly incorrect imports.The fix is to do a second pass, since we already identify the largest triangle as the reference for a plane, we can simply check if any verts in the plane are out of that triangle's plane. If so, we simply discard the entire plane and all contained triangles are assumed to be not coplanar with each other. There are a few edge cases where this will miss actual planar faces, but I think they'll be rare, and it's much less of a problem geometrically to be conservative in this direction.