Workaround assimp exporting empty 3mfs #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #454 +/- ##
=======================================
Coverage 89.94% 89.94%
=======================================
Files 35 35
Lines 4285 4285
=======================================
Hits 3854 3854
Misses 431 431 ☔ View full report in Codecov by Sentry. |
elalish
approved these changes
Jun 15, 2023
jmicahc
pushed a commit
to SovereignShop/manifold
that referenced
this pull request
Jul 4, 2023
Workaround assimp producing meshless 3mf files by nesting the node holding the mesh into a child of the root node if the extension is .3mf
Merged
cartesian-theatrics
pushed a commit
to SovereignShop/manifold
that referenced
this pull request
Mar 11, 2024
Workaround assimp producing meshless 3mf files by nesting the node holding the mesh into a child of the root node if the extension is .3mf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something that I actually noticed a long time ago, but forgot to mention or return to myself, but 3mf export via
MeshIOdoesn't actually work (a file containing no meshes is written).There is actually a long standing issue for this in the assimp tracker, but fortunately it has an easy workaround. This PR implements that workaround by nesting the node holding the mesh into a child of the root node if the extension is
.3mf.