fixed WASM segfault #474
Merged
fixed WASM segfault #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #474 +/- ##
=======================================
Coverage 89.94% 89.94%
=======================================
Files 35 35
Lines 4286 4286
=======================================
Hits 3855 3855
Misses 431 431
☔ View full report in Codecov by Sentry. |
jmicahc
pushed a commit
to SovereignShop/manifold
that referenced
this pull request
Jul 4, 2023
Merged
cartesian-theatrics
pushed a commit
to SovereignShop/manifold
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #432
Turns out this problem had nothing to do with
Merge, but rather with constructing a manifold with an odd number of triangles. Of course this can't be a valid 2-manifold ever, but we create the halfedges before we check manifoldness, and whennumTriwas odd, a round-down was making our array too short, causing a segfault that for some reason only WASM noticed.I also updated out .gitignore.