fix openscad build #539
Merged
fix openscad build #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #539 +/- ##
=======================================
Coverage 91.32% 91.32%
=======================================
Files 35 35
Lines 4543 4543
=======================================
Hits 4149 4149
Misses 394 394
☔ View full report in Codecov by Sentry. |
|
I think I have correctly switched the submodule but I'm still getting the build error. Build log: How can I check that |
|
Ouchies! Maybe it's time to look at submitting an updated TBB package to MXE... that would remove the need for the |
it is weird, I did add a tbb version check in |
elalish
approved these changes
Aug 28, 2023
|
I think the windows failure is due to AngusJohnson/Clipper2#601 |
|
@t-paul I think I know the reason why pstl was not disabled, I forgot to check for TBB version before including |
|
ok it seems that both max and min are problematic on windows... |
pca006132
force-pushed
the
compile-options
branch
from
4d1e682
to
b4e1d99
Compare
|
I'm now getting BTW: This is running in a docker container, so if you have some place where you can run an existing container, I can post the build steps I just copy&paste into the running container. If I'm reading that correctly, it's failing to determine the byte order of the system. It tracks |
|
Oh OK, our CI does not include mingw, I guess that is why we did not catch this issue earlier. I can run containers. Not sure if I can run windows container without a VM, but yeah it would be easier if you can paste the instructions here. |
|
Good news, I think it got past MXE is a cross-build environment running MinGW on Linux + providing a packaging system, so it does not require Windows at all. Run ad-hoc base container with all packages needed for OpenSCAD compiled: Commands that are used to build, including updating the git repo to this PR: I literally just copy all those lines and paste them into a freshly started container. |
|
@t-paul the build should now succeed. The MXE build environment is also added to our CI, which can hopefully catch this kind of issues for our subsequent changes. |
|
Awesome, thank you! I'll give it a try and see if someone can verify the build is running fine. I still have some issues with running those in my Windows VM, probably due to some legacy OpenGL code in OpenSCAD which is currently in the process of being removed. So there's some hope I can do some limited testing again soon-ish. |
|
good, I guess I will merge this first, and feel free to open an issue when you found any bug (except #535 which is known for now) |
|
Builds look good for the AppImage and Windows build 🎉. There an issue that's crashing the application after mutliple runs we still need to investigate, but that's unlikely to be related to those changes here and/or even Manifold itself. Many thanks for getting the builds working on those older or slightly strange platforms working. |
|
Indeed, well done @pca006132! |
cartesian-theatrics
pushed a commit
to SovereignShop/manifold
that referenced
this pull request
Mar 11, 2024
* fix openscad build * update clipper2 * conditional compile with pstl * try NOMINMAX for MSVC * detect win32 * use struct instead of lambda * fix non-tbb build * try to add mxe to CI * disable pybind for mxe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openscad/openscad#4679 (comment)
MANIFOLD_FLAGSto downstream consumers.I think we should probably put
public.hinto a separate directory as well, as other headers in utilities are not supposed to be visible to users.@t-paul can you verify if this patch fixes the compilation errors for you?