Exceptions not properly caught

[schuettloeffel-elsa]

On network connection issues, the php exceptions are not caught properly, so at the end a different message is presented to the user:

Instead, this message should be presented: https://github.com/elan-ev/studip-meeting/blob/master/lib/Helpers/MeetingsHelper.php#L176

Can be fixed by resolving namespace issue:

diff --git a/lib/Helpers/MeetingsHelper.php b/lib/Helpers/MeetingsHelper.php
index 31308e7..d1fa05d 100644
--- a/lib/Helpers/MeetingsHelper.php
+++ b/lib/Helpers/MeetingsHelper.php
@@ -192,7 +192,7 @@ class MeetingsHelper
             } else {
                 $error_message = I18N::_('Konnte dem Meeting nicht beitreten, Kommunikation mit dem Meeting-Server fehlgeschlagen.');
             }
-        } catch (Exception $e) {
+        } catch (\Exception $e) {
             $error_message = I18N::_('Konnte dem Meeting nicht beitreten, Kommunikation mit dem Meeting-Server fehlgeschlagen. ('. $e->getMessage() .')');
             throw new Error($error_message, ($e->getCode() ? $e->getCode() : 404));
         }
@@ -295,4 +295,4 @@ class MeetingsHelper
         }
     }

[ferishili]

Hi @schuettloeffel-elsa
That would be great if you could test the linked PR

Thanks in advance

[schuettloeffel-elsa]

Yeah should work, we had this fix working for some time