Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message in case sync.{user/password} are incorrect #1000

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

LukasKalbertodt
Copy link
Member

Fixes #828

Error message before:

▸ Connection to Opencast harvesting API  ✘ error
     ▶▶▶ Error: failed to fetch API version
     Caused by:
      ‣ API returned unexpected HTTP code 401 Unauthorized (for 'https://develop.opencast.org/tobira/version')

After:

 ▸ Connection to Opencast harvesting API  ✘ error
      ▶▶▶ Error: failed to fetch API version
      Caused by:
       ‣ Requesting 'https://develop.opencast.org/tobira/version' with login 'admin:******' returned 401 Unauthorized. Check 'sync.user' and 'sync.password'!

Its not ideal that the URL is in the beginning but I haven't found another good way to phrase that. In either way, it should be clear what the problem is.

@LukasKalbertodt LukasKalbertodt added the changelog:admin Changes primarily for admins label Nov 16, 2023
@github-actions github-actions bot temporarily deployed to test-deployment-pr1000 November 16, 2023 13:29 Destroyed
@owi92
Copy link
Member

owi92 commented Nov 17, 2023

Working, and definitely a convenient improvement.

@owi92 owi92 merged commit bf764af into elan-ev:master Nov 17, 2023
3 checks passed
@LukasKalbertodt LukasKalbertodt deleted the improve-sync-error branch November 20, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:admin Changes primarily for admins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check should acknowledge about what credentials is using
2 participants