Extend edit series block #1058
Extend edit series block #1058
Conversation
|
Thanks for the PR! I don't have time to look at it in detail yet, but this feature seems reasonable! And you can ignore the failing "admin UI check" for now, that's likely a temporary failure and not caused by your PR. Will come back to this PR soon (TM). |
github-actions
bot
added
the
status:conflicts
|
This pull request has conflicts ☹ |
|
FYI: we will merge another PR that will cause some conflict with this one soon, so probably not worth it starting to resolve conflicts now. We did that because we wanted to include a bunch of stuff in a small release very soon, while yours would be in the release afterwards. If you want, we can resolve the conflicts for you, just let me know. |
geichelberger
force-pushed
the
new-default-values-series-block
branch
from
a02515c
to
9ab900b
Compare
github-actions
bot
removed
the
status:conflicts
|
I changed the CSS of the edit series form because the 400px max width wasn't enough to display all options. This is maybe a controversial change (9ab900b) |
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
the
status:conflicts
|
Sorry, your PR is next, I promise 🙈 |
There was a problem hiding this comment.
Looks really good! I only have very few small comments. After those are fixed and conflicts are resolved, this can be merged.
The offer still stands that I can rebase/fix conflicts for you. Then I can also fix my comments. Just let me know.
EDIT: and for the record, the failing "admin ui" GH action is no problem. Changing NewSeries would potentially break the admin UI, but you are only changing NewSeriesBlock. Due to an incorrect startsWith in our test script, it fails. So yeah: nothing to worry about. Lets just ignore it.
frontend/src/routes/manage/Realm/Content/Edit/EditMode/Series.tsx
Outdated
Show resolved
Hide resolved
geichelberger
force-pushed
the
new-default-values-series-block
branch
from
895fea3
to
76402c3
Compare
github-actions
bot
removed
the
status:conflicts
Adds new series block configurable default values. - Extend video list order with the `A-Z` and `Z-A` options. - Add video list view options (List, Gallery, Slider) Signed-off-by: Gregor Eichelberger <gregor.eichelberger@tuwien.ac.at>
Signed-off-by: Gregor Eichelberger <gregor.eichelberger@tuwien.ac.at>
Fixing the migration script for existing databases by splitting the `alter table` statement into two parts. The first statement adds the new `videolist_view` column and sets the default value for existing rows. The second statement removes the column default and updates the constraints. Signed-off-by: Gregor Eichelberger <gregor.eichelberger@tuwien.ac.at>
geichelberger
force-pushed
the
new-default-values-series-block
branch
from
76402c3
to
4eda5b1
Compare
geichelberger
force-pushed
the
new-default-values-series-block
branch
from
780dddc
to
8052737
Compare
Adds new series block configurable default values.
A-ZandZ-Aoptions.