Filter out past live events from search results in backend #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the frontend filtered out those events. But this lead to weirdness where there "number of hits" were incorrect and if everything was filtered out, the "no results" was not shown, but no result was shown either. This moves this completely to the backend. Which means that due to communication delay, the frontend could show live events that just ended. But that's fine I think. Also, this filtering is not done for the event search in the block edit UI. Maybe people want to find past live events there 馃し
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the frontend filtered out those events. But this lead to weirdness where there "number of hits" were incorrect and if everything was filtered out, the "no results" was not shown, but no result was shown either.
This moves this completely to the backend. Which means that due to communication delay, the frontend could show live events that just ended. But that's fine I think.
Also, this filtering is not done for the event search in the block edit UI. Maybe people want to find past live events there 馃し
This can be tested by searching for
"NASA TV"(with quotes). On our current deployment one result is shown but it says "2 hits".