Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make logout button work with keyboard #1083

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Make logout button work with keyboard #1083

merged 1 commit into from
Jan 16, 2024

Conversation

owi92
Copy link
Member

@owi92 owi92 commented Jan 16, 2024

Fixes #1072

@owi92 owi92 added the changelog:nope Not worth mentioning in the changelog label Jan 16, 2024
@github-actions github-actions bot temporarily deployed to test-deployment- January 16, 2024 16:21 Destroyed
@github-actions github-actions bot temporarily deployed to test-deployment-pr1083 January 16, 2024 17:36 Destroyed
LukasKalbertodt
LukasKalbertodt reviewed Jan 16, 2024
View reviewed changes
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with enter and mouse! Just one tiny thing, since you touched this code anyway.

frontend/src/layout/header/UserBox.tsx Outdated Show resolved Hide resolved
@LukasKalbertodt LukasKalbertodt added changelog:user User facing changes and removed changelog:nope Not worth mentioning in the changelog labels Jan 16, 2024
@github-actions github-actions bot temporarily deployed to test-deployment-pr1083 January 16, 2024 17:50 Destroyed
@LukasKalbertodt LukasKalbertodt merged commit f9e74e3 into elan-ev:master Jan 16, 2024
3 checks passed
@owi92 owi92 deleted the logout-enter branch March 4, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasKalbertodt LukasKalbertodt LukasKalbertodt left review comments

Assignees
No one assigned
Labels
changelog:user User facing changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make logout button work with enter key again
2 participants
@owi92 @LukasKalbertodt