Apollo + GraphQL code generator showcase #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just for getting familiar with all GraphQL tooling/libraries and will be completely removed later.
It works, but one thing is still problematic: the `gql` JS template does not generate TS typings. There are a few way to pre-process gql, but none of those generates types either I think. We can manually specify types, but this feels like duplication, as the schema already defines all the types. Maybe specifying types in the frontend again is good to make sure frontend and backend agree on the types. But in that case we would like to have a test to check that both agree on the types. So in either way, we need some way to generate types from the schema and `gql` invocations.
This more or less solves one problem of the "Apollo only" approach. Apparently it is also possible to use the relay compiler with the "GraphQL code generator" to optimize queries. Disadvantages of this approach: - Yet another CLI to run as build step - The `data` type always includes `| undefined` due to Apollo sometimes returning that (e.g. when passing `skip: true`). This could be annoying to always assert it is not `undefined`. - All generated code is in one file, so when defining query names, one has to look out for name clashes. It would be nicer if for each `.graphql` file, a tsx file is generated to have locally scoped names. We can have that, if we add an entry for each file in `codegen.yml`, but that's meh. - We need the schema file somewhere.
LukasKalbertodt
force-pushed
the
gql-codegen-showcase
branch
from
4479a3c
to
d89527b
Compare
|
Superseded by #21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR serves just as an example how the Apollo GraphQL JS library works in combination with the "GraphQL Code generator". This PR is based on #10. See this document for context.