Stop using non-existent Roboto fonts in Paella #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasKalbertodt
force-pushed
the
fix-paella-font
branch
2 times, most recently
from
a08714a
to
b9189bc
Compare
The Paella skin we use loads Robot files and sets Roboto as font for the whole player. For some time now, those requests to the font files failed, creating annoying errors. So unless you already had Robot installed locally, Paella used the font set by Tobira. We discussed this internally and decided that having two similar, but still different fonts on a website is not a good idea. So this removes the font declarations in the skin. In a ... hacky way sadly. But we already heavily modify Paella code to our advantage.
LukasKalbertodt
force-pushed
the
fix-paella-font
branch
from
b9189bc
to
df12d58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Paella skin we use loads Robot files and sets Roboto as font for the whole player. For some time now, those requests to the font files failed, creating annoying errors. So unless you already had Robot installed locally, Paella used the font set by Tobira.
We discussed this internally and decided that having two similar, but still different fonts on a website is not a good idea. So this removes the font declarations in the skin. In a ... hacky way sadly. But we already heavily modify Paella code to our advantage.