Add configurable "terms and conditions" popup #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This holds configurable title, text and button label for the terms and conditions prompt. Co-Authored-By: Ole Wieners <olewieners@yahoo.com>
This is a really basic consent modal, that is only closeable by agreeing to the configured terms and conditions. Users are prompted when first visiting Tobira. The consent is saved in local storage, meaning it is done on a per-device basis rather than per-user. Users are re-prompted once any texts change in the language they originally agreed to. It is slightly annoying that the logic isn't fully contained in one file, but the async nature of the `digest` function is annoying. This is the easiest way to do this that avoids one-frame flickering of the popup dialog, for example.
LukasKalbertodt
force-pushed
the
terms-and-conditions
branch
from
c97e09f
to
a863231
Compare
LukasKalbertodt
changed the title
LukasKalbertodt
force-pushed
the
terms-and-conditions
branch
from
a863231
to
0ea9052
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1103
Closes #1023
The consent is stored in local storage, and thus is bound to a device (+ browser & OS) and not to a (logged-in) user. We need this functionality anyway for users that never log in. In #1023 it was suggested that we also store the consent in the DB for logged-in users. In theory that means logged-in users never see the prompt again, but in practice this is not useful: since the prompt is in front of everything, the user has to agree to it before logging in. So the DB-stored value would never be used, except in very rare cases.
Tobira asks for consent again once the configured texts change. Or more specifically: the texts in the language shown to the user when clicking "Agree". That means new languages can be added without re-prompting all users.