Switch to login callback for local development & deployment server #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the added changelog. This commit is mainly preparation to add functions for implementing callbacks.
Yes, this prints passwords but this is just for the dev environment and our test deployments.
This makes the setup a bit simpler. This also enables easier setup of isolated Playwright tests.
How to specify UDS in a URL is non-standardized at all. Also see github.com/whatwg/url issue elan-ev#577. We used one option that seems to be reasonable and used by others. Currently does not support paths with `]` yet, which can be supported by percent-encoding that.
LukasKalbertodt
force-pushed
the
switch-to-login-callback
branch
from
11c6d25
to
20652fb
Compare
owi92
requested changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes our local dev setup and the test deployment to using login-callbacks instead of the old "login-proxy" way of handling auth. The main motivation behind that is that it makes for an easier setup in #1093, but this also makes some things simpler (e.g. nginx config) and our docs already recommend callbacks over auth headers.
To switch over, this PR adds support for unix domain sockets (UDS) for login/auth handlers. It also updates
authkitto work with the new auth setups. Finally, there are also improvements and fixes for a few other minor things. See commits for more detail.Once this is merged, I would add hints about
authkitto the docs again and then release authkit as 0.2.0.