Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve screen reader accessibility #1136

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Improve screen reader accessibility #1136

merged 3 commits into from
Mar 7, 2024

Conversation

owi92
Copy link
Member

@owi92 owi92 commented Mar 6, 2024

Closes #643

@owi92 owi92 added the changelog:user User facing changes label Mar 6, 2024
@github-actions github-actions bot temporarily deployed to test-deployment-pr1136 March 6, 2024 17:04 Destroyed
LukasKalbertodt
LukasKalbertodt requested changes Mar 7, 2024
View reviewed changes
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I can confirm that the text read by my screen reader changed as suggested by the changes. So with the three remarks fixed, this can go in and closes the linked issue.

frontend/src/i18n/locales/en.yaml Outdated Show resolved Hide resolved
frontend/src/i18n/locales/en.yaml Outdated Show resolved Hide resolved
frontend/src/routes/manage/Video/index.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to test-deployment-pr1136 March 7, 2024 10:26 Destroyed
@LukasKalbertodt LukasKalbertodt merged commit 0f3eb6a into elan-ev:master Mar 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasKalbertodt LukasKalbertodt LukasKalbertodt approved these changes

Assignees
No one assigned
Labels
changelog:user User facing changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Screen reader related accessibility issues
2 participants
@owi92 @LukasKalbertodt