Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable block editing UI tests #1147

Merged
merged 8 commits into from
May 15, 2024
Merged

Reenable block editing UI tests #1147

merged 8 commits into from
May 15, 2024

Commits on Apr 3, 2024

  1. Replace navigateTo helper with builtin goto

    @owi92
    owi92 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    8343a44 View commit details
    Browse the repository at this point in the history

  2. Move some code to util functions

    @owi92
    owi92 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    5d8b060 View commit details
    Browse the repository at this point in the history

  3. Reenable block editing UI tests

    @owi92
    owi92 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    3e9d03a View commit details
    Browse the repository at this point in the history

  4. Remove unused function

    @owi92
    owi92 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    3ecdba6 View commit details
    Browse the repository at this point in the history

  5. Improve edit-button locating 

    This replaces the `nth()` locator with more specific ones.
Using `nth()` is apparently discouraged and indeed lead
to some flaky behaviour in the block editing tests.
The buttons are now located by using specific unique locators.
Blocks containing only text content like title and text blocks
can be located by using a regex filter, while the video and series
blocks can be located by combining a filter that checks the
presence of specific text with a filter that checks for
the absence of other specific text (that is contained in another
block).
However, we do need to make sure that the test steps are
performed in a set order: If the text whose presence is checked
is removed in a test step, that step needs to be the very last one
of that specific block. Otherwise the locator will fail.

This also incidentally inlines all the block editing instead of
having one large function for it. I do maintain that the function
was nicer, but with these new locators it has gotten somewhat
pointless.
    @owi92
    owi92 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    a08a0d8 View commit details
    Browse the repository at this point in the history

  6. Rebase onto master

    @owi92
    owi92 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    6c39433 View commit details
    Browse the repository at this point in the history

  7. Remove utils/common file 

    Since all functions and structures were either
moved to more specific files or removed completely,
the only thing this file did was reimport/export
the test function for convenience. That can now be
imported directly in the test files.
    @owi92
    owi92 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    8d66617 View commit details
    Browse the repository at this point in the history

  8. Use user realm from fixtures in realm tests

    @owi92
    owi92 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    9d412df View commit details
    Browse the repository at this point in the history