Adjust spacing of forwards and backwards button text #1150
Conversation
|
Mh I think this doesn't yet solve the issue in that the "forward" number is closer to the arrow than the "backwards" one. So the "forward" number has to be moved right more than the "backwards" number left, but this PR moves both by the same amount. I also wouldn't change the vertical position that much. In this new version the numbers are below the baseline of the other text in the same line. But sure, in the end this is subjective. |
It is literally only changed by one pixel though... Or am I seeing this wrong. I mean it also says so in the code so I don't know... what would you suggest? |
|
One whole pixel?! Back in my days... Seriously though: I directly compared the new and old ones by switching between two tabs and... somehow it is a noticeable change. No idea why this one pixel is doing that. Maybe this is in SVG coordinates and everything gets scaled up or sth? |
owi92
force-pushed
the
balance-ff-button
branch
from
edf955e
to
68c88e3
Compare
Since these are basically mirrored (not completely because the number 10 is obv not), the x-offset does not necessarily need to be the same. It's kinda hard to tell honestly, so I tried around a bit with different values and think to have ended up with an improved balancing. Though that is still somewhat subjective of course.
owi92
force-pushed
the
balance-ff-button
branch
from
68c88e3
to
8cabf84
Compare
Since these are basically mirrored (not completely because the number 10 is obv not), the x-offset of the number does not necessarily need to be the same. It's kinda hard to tell, so I tried around a bit with different values and also increased the y-offset of both by one pixel. I might have ended up with an improved balancing. Though that is still somewhat subjective of course, so feedback is still welcome.
Closes #1086