Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Paella plugins #1162

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Update Paella plugins #1162

merged 5 commits into from
Apr 29, 2024

Conversation

owi92
Copy link
Member

@owi92 owi92 commented Apr 22, 2024

Updates:

  • paella-basic-plugins 1.44.4 -> 1.44.7
  • paella-skins 1.32.4 -> 1.48.0
  • paella-zoom-plugin 1.41.1 -> 1.41.3

Also sets the currently set language in Tobira for Paella, and provides english as a fallback default language in Paella's configuration.

@owi92 owi92 added the changelog:user User facing changes label Apr 22, 2024
@github-actions github-actions bot temporarily deployed to test-deployment-pr1162 April 22, 2024 19:11 Destroyed
@github-actions github-actions bot temporarily deployed to test-deployment-pr1162 April 22, 2024 20:43 Destroyed
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The language stuff works as expected and I also see the new icons. As you already noted in chat, the icon colors are not ideal. It seems like paella-skins does not actually define a color for the icon and the SVG uses currentColor (which is apparently either black or white, depending on the color scheme). Can you try to find a fixed color that works well? A few thoughts:

  • The color should probably not change with color scheme as nothing else inside the Paella div changes.
  • Maybe make the thing more opaque? 60% seems rather transparent?
  • The color should probably be a grey, but not white or black.
  • Is it possible to make a hover effect that slightly changes the color (or opacity) when any part of the player is hovered? I think that might be nice.

I would suggest that you just experiment with this (using CSS rules in Tobira) and once we are happy, we can upstream the CSS rules into paella-skins.

frontend/src/ui/player/Paella.tsx Outdated Show resolved Hide resolved
frontend/src/typings/paella-core.d.ts Outdated Show resolved Hide resolved
@owi92
Copy link
Member Author

owi92 commented Apr 24, 2024

The color should probably be a grey, but not white or black

I think a pure-ish grey doesn't work that great, and I much prefer a lighter color, close to what it is now (or even before my push in dark mode).

For a quick comparision:

  • stock color in dark mode (with higher opacity):
Bildschirmfoto 2024-04-24 um 16 37 59
  • current iteration (this PR):
Bildschirmfoto 2024-04-24 um 16 38 21

I think I would actually prefer the top version, but it's not a huge difference anyway.

Here is a version with "pure" (i.e. #808080) grey:
Bildschirmfoto 2024-04-24 um 16 42 59

@github-actions github-actions bot temporarily deployed to test-deployment-pr1162 April 24, 2024 14:47 Destroyed
@LukasKalbertodt
Copy link
Member

Oh, by "grey" I wasn't talking about #808080, but just about "any grey tone", i.e. no saturation with any color. So i wasn't ruling out brighter or darker ones.

I like the hover effect now. Might even be a bit stronger still? Maybe just opacity 1 on hover?

Regarding color: i like it for most videos, but it has problems with certain ones: https://pr1162.tobira.opencast.org/v/BxcXNwghXfK

image

Of course there is no magic color that works for all videos: there can always be a video that matches the color we pick. So my natural instinct is to somehow put a semi-transparent black background behind the icon. Probably very blurred. But not sure how good that looks and if we can even do it with hacky CSS?

I compared it to YouTube: that does suffer from the same problem in theory:

Without hover:

image

When hovered:

image

YouTube of course autoplays whenever the laws of physics allow it, so users usually don't see that. And the hover effect is stronger and also makes sure that either the non-hover icon or the hover icon is clearly visible on the background (since they have such different colors).

So yeah, no idea. Maybe it's fine the way you did it, because users will just click on the video anyway. But maybe you have a good idea to improve the situation?

@owi92
Copy link
Member Author

owi92 commented Apr 28, 2024

maybe you have a good idea to improve the situation?

I worked out two possible solutions for this:

  • Something like you suggested with a blurred background (using backdropFilter: "invert(12%) blur(4px)" and a couple of css lines for centering and some extra juice to make it work in safari......):
Bildschirmfoto 2024-04-28 um 16 06 28
  • Or just a subtle drop shadow on the svg:
Bildschirmfoto 2024-04-28 um 16 06 03

Both work with pretty much all backgrounds.
I prefer the second one. It's looks cleaner™ to me and has none of the somewhat hacky css required for the first suggestion.

@LukasKalbertodt
Copy link
Member

Yep I agree, the second solution looks good! Lets just go with that.

@github-actions github-actions bot temporarily deployed to test-deployment-pr1162 April 29, 2024 08:59 Destroyed
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks :)

@LukasKalbertodt LukasKalbertodt merged commit 07251d2 into elan-ev:master Apr 29, 2024
4 checks passed
@geichelberger
Copy link
Contributor

The new play button is in your face, and for me, it doesn't quite fit the rest of the design.

@owi92
Copy link
Member Author

owi92 commented May 2, 2024

@geichelberger I agree, and Lukas and I talked about this. Before we change it again, we wanted to check back with @oas777 and @dagraf first. I would probably make the icon a little smaller and reduce its stroke-width (i.e. making it less thick). This would result in something like in the below screenshot. Might be a little too subtle so it still needs some tweaking. Would you prefer a different icon altogether?
Bildschirmfoto 2024-05-02 um 13 37 20

@geichelberger
Copy link
Contributor

That looks better than the original, and maybe use an acute triangle instead of an equilateral triangle.

@oas777
Copy link
Collaborator

oas777 commented May 2, 2024

Before I comment this: Could someone please shortly explain to me how we came from polimediaupv/paella-skins#5 and the dark grey / black of https://polimediaupv.github.io/paella-skins/ to this new light grey version?

@owi92
Copy link
Member Author

owi92 commented May 2, 2024

@oas777 The color of the play and spinner icons from https://polimediaupv.github.io/paella-skins/ is dependent on light/dark mode. Light mode uses the dark grey/black, while dark mode uses a similar tone to what you see in my screenshots.

The dark version is hard to see on dark-ish preview images and the black canvas that is shown when a video is loading (which is always black, independent of light or dark mode). So I think it's better to always use the light grey version.

@oas777
Copy link
Collaborator

oas777 commented May 2, 2024

Thanks, @owi92 for your late night explanations. Some random thoughts:

  • I prefer the darker grey in general.
  • I think with lecture recordings predominant, we will see many white preview images of slides.
  • I would like to ignore the problems people have in dark mode. But then: accessibility. So light grey.
  • I prefer the thicker version(s).
  • I agree with @geichelberger about an equilateral triangle not being ideal.

@owi92
Copy link
Member Author

owi92 commented May 3, 2024

I prefer the darker grey in general.
I think with lecture recordings predominant, we will see many white preview images of slides.

I suppose we can make a dark version work. I can see your point about most preview images being white. Though at least the spinner would need some sort of outline. That is always shown on a black background, regardless of color scheme.

I would like to ignore the problems people have in dark mode. But then: accessibility. So light grey.

It's really not about dark vs light mode. What I mean is that the icons inside paella should be colored independently of the overall color scheme set in Tobira.

I prefer the thicker version(s).

I'm sure there is a middle ground to be found here.

I agree with @geichelberger about an equilateral triangle not being ideal.

I'm not sure if changing only the triangle of the current icon is possible. It might, but we might also need a different icon altogether.

But let's discuss these things in our meeting next week.

@LukasKalbertodt
Copy link
Member

Can someone explain to me what you dislike about the equilateral triangle? But yes as Ole said: this is the play icon of our icon pack of choice. We don't really want to tweak parts of it, but use the exact icons from the pack for consistency.

In addition to what Ole said: Paella did not define a color for the icon at all. So the black you see here https://polimediaupv.github.io/paella-skins/ is just a "happy accident". I don't mind changing the grey-tone of the icon again though. And once we're happy with it in Tobira, we should push these changes back to paella-skins.

@dagraf
Copy link
Collaborator

dagraf commented May 8, 2024

I would probably make the icon a little smaller and reduce its stroke-width (i.e. making it less thick).

I would vote for making it smaller and reduce its stroke-width and aim for this 'middle ground'.

Additionally:

  • The equilateral triangle I do not see as a problem.
  • I would prefer a grey that is a little bit darker, too.

@oas777
Copy link
Collaborator

oas777 commented May 11, 2024

Can someone explain to me what you dislike about the equilateral triangle?

I recall my "vote" against the equilateral triangle for it gives the icon a certain symmetry. Plus the user a headache when you realise it points in three directions.

I would vote for making it smaller and reduce its stroke-width and aim for this 'middle ground'.

Let's see that middle ground then ...

@owi92
Copy link
Member Author

owi92 commented May 13, 2024

Let's see that middle ground then ...

I made some adjustments in #1165.
I would suggest you take a look at a couple of videos with different backgrounds. I still think the lighter version works better for a variety of backgrounds, but if as you said the majority of videos will have a white background anyway, the darker version should be ok to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:user User facing changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants