Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comment in config for general.initial_consent #1201

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Fix comment in config for general.initial_consent #1201

merged 1 commit into from
Jul 4, 2024

Conversation

LukasKalbertodt
Copy link
Member

The field is called button not button_label. Found by Piri.

@LukasKalbertodt
Fix comment in config for general.initial_consent
fc44761 
The field is called `button` not `button_label`.
@LukasKalbertodt LukasKalbertodt added the changelog:admin Changes primarily for admins label Jul 4, 2024
@github-actions github-actions bot temporarily deployed to test-deployment-pr1201 July 4, 2024 13:11 Destroyed
owi92
owi92 approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@owi92 owi92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @Piriya-VM 🙏

@owi92 owi92 merged commit df20cda into elan-ev:master Jul 4, 2024
5 checks passed
@LukasKalbertodt LukasKalbertodt deleted the fix-tac-comment branch July 4, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owi92 owi92 owi92 approved these changes

Assignees
No one assigned
Labels
changelog:admin Changes primarily for admins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LukasKalbertodt @owi92