Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for changes to APIs used by the admin UI integraiton in PRs #552

Merged
merged 3 commits into from
Oct 13, 2022

Conversation

JulianKniephoff
Copy link
Member

Some notes:

  • I tried to reproduce the behavior of our conflict check, running even when the base branch changes. This is not trivial, though. It's a feature of the action we use in that check, not of the actions/workflow system. It reacts to push events and then manually goes through all the PRs to check and mark them.
  • I opted not to let this action label the PR, yet, simply because I'm not sure what label to use. I welcome in put on this point.

@JulianKniephoff JulianKniephoff added area:ci Continuous Integration kind:new-feature A new feature changelog:dev Changes primarily for developers labels Sep 19, 2022
@github-actions
Copy link

🚀 This PR was deployed at https://pr552.tobira.opencast.org. The deployment will be updated whenever someone pushes onto this PR's branch.

Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Just one comment/question.

- name: Check for changes to the APIs the admin UI integration uses
id: graphql_inspector
run: |
npx @graphql-inspector/cli@3.4.0 diff \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently there is an extra version for CI environment: https://www.the-guild.dev/graphql/inspector/docs/products/ci

I guess we should use that instead of this CLI?

@LukasKalbertodt LukasKalbertodt merged commit 4c834af into elan-ev:master Oct 13, 2022
@JulianKniephoff JulianKniephoff deleted the check-adminui-api branch October 19, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ci Continuous Integration changelog:dev Changes primarily for developers kind:new-feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants