Apply hover styles also on keyboard focus #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the `:focus` selector to almost all elements that feature a style that is being applied on hover events. This should improve the usability of keyboard-only navigation. Exceptions are elements that are not keyboard-focusable, like the "logged in as <username>" and upload date on video pages.
|
Tested this using the deployment: Looks good. I didn't notice any large problems. It definitely fixes the problematic buttons I noticed before. |
|
Thank you for testing! Just to clarify, the issue described in #649 is fixed by line 48 in |
LukasKalbertodt
approved these changes
Jan 17, 2023
| @@ -175,7 +175,7 @@ const EventTable: React.FC<EventTableProps> = ({ events, vars }) => { | |||
| }, | |||
| }, | |||
| "& > tbody": { | |||
| "& > tr:hover": { | |||
| "& > tr:hover, tr:focus-within": { | |||
There was a problem hiding this comment.
I think you are missing a & > here? It seems to work anyway. Mh. I have the strong feeling that most & I used are not necessary :D
Suggested change
| "& > tr:hover, tr:focus-within": { | |
| "& > tr:hover, & > tr:focus-within": { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
:focusselector to almost all elements that feature a style that is being applied on hover events. This should improve the usability of keyboard-only navigation. Exceptions are elements that are not keyboard-focusable, like the "logged in as " and upload date on video pages.Closes #649