Make Tobira work with PostgreSQL schemas other than public
#664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianKniephoff
requested changes
Jan 18, 2023
Tobira should be able to run inside different schemas as well.
The old version would fail in some situations when the db user was not allowed to delete the schema. We don't want to delete it anyway, but just everything in it. So doing exactly that is more straight forward anyway. Unfortunately, it's a bit more involved as we have to list all objects to be deleted. We do this by using `information_schema` but also `pg_catalog`, unfortunately. The latter is not standard SQL and can potentially change in future versions. Though those tables have changed very little in the last few years. Our queries are likely to still work in future versions of PostgreSQL. And this is just one helper sub-command anyway. The other question is: does this indeed delete all kinds of objects in the DB? Well, probably not, but I'm fairly sure it deletes all the ones that our migrations create. I tested this a couple of times, running `db migrate` and `db clear` back to back and all works as expected. I tested with PG10 and PG15. I also checked in a GUI tool and didn't see any remaining objects of interest.
LukasKalbertodt
force-pushed
the
fix-pg-schemas
branch
from
a2603c3
to
d723728
Compare
JulianKniephoff
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #635
This implements what I described in this comment. See commits for further information.