Rerender the current route on every navigation #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to how React works, this previously only happened when you actually visited a new route. Visiting the same route would **not** rerender and thus also not reset any state. This is unexpected for example when you click the "upload video" button in the users menu while already uploading something.
JulianKniephoff
added a commit
to JulianKniephoff/tobira
that referenced
this pull request
Jan 30, 2023
With elan-ev#680 merged, there now is a more elegant way to reset the state of the uploader; we can just send the user to the route again!
owi92
added a commit
that referenced
this pull request
Jan 30, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to how React works, this previously only happened when you actually visited a new route. Visiting the same route would not rerender and thus also not reset any state.
This is unexpected for example when you click
the "upload video" button in the users menu while already uploading something.
Closes #681.