Make uploader show error when selecting non-video or -audio files #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owi92
reviewed
Feb 21, 2023
owi92
requested changes
Feb 21, 2023
LukasKalbertodt
force-pushed
the
check-mime-type-uploader
branch
from
bdfbaf4
to
44161c7
Compare
owi92
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #682
This could technically make some things that worked before fail now. Either because Opencast can deal with some files that have a non
video/oraudio/mime type. Or because the browser doesn't correctly infer the MIME type. MDN says that browser don't read the file but judge purely from the file name extension. And that for rare or ambiguous extensions, it might return an empty MIME type. I think this should be fine, but I'm not entirely sure and have no idea. How I would find out more :/