Replace "home" link title with aria-label #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree that the tooltip isn't really helpful here. So without the tooltip this can be merged. |
This replaces the `title` attribute of the link with an `aria-label`, as `title` won't be announced by many screen readers.
owi92
force-pushed
the
add-home-link-description
branch
from
0bb5fec
to
3cb06d3
Compare
owi92
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the
titleattribute of the link with anaria-label, astitlewon't be announced by many screen readers. It also adds a tooltip to the link, but I'm not sure if that is really necessary (I'm leaning towards no as it might be redundant and also a little distracting in this instance).Closes #646