Add alphabetical ordering options to series blocks #742
Conversation
owi92
force-pushed
the
alphabetic-ordering-for-events
branch
from
68527f8
to
544fe56
Compare
frontend/src/ui/Blocks/Series.tsx
Outdated
| "A-Z": () => a.title.toLowerCase() > b.title.toLowerCase() ? 1 : -1, | ||
| "Z-A": () => a.title.toLowerCase() > b.title.toLowerCase() ? -1 : 1, |
There was a problem hiding this comment.
This should use localeCompare as the expected string order actually depends on the locale: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/localeCompare
I think this also already deals with casing (in that it ignores it, if the locale says so)
There was a problem hiding this comment.
You still need to pass in the correct language thats set in Tobira. You can compare sortRealms in routes/util.tsx. There we also create an Intl.Collator as MDN says thats better for performance: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/localeCompare#performance
You can const { t, i18n } = useTranslation() and then use i18n.language or something like that.
owi92
force-pushed
the
alphabetic-ordering-for-events
branch
from
544fe56
to
c3fe46f
Compare
owi92
force-pushed
the
alphabetic-ordering-for-events
branch
from
c3fe46f
to
8bb94f5
Compare
New ordering options are from
a to zandz to a.Ordering is now also applied for upcoming events.