Add specific descriptions to copyable inputs #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the buttons to copy the video link, embed code and opencast-id all shared the same generic "copy to clipboard" description. Now each one has its own description for screen reader use.
The wave plugin was complaining about missing form labels of the copyable inputs. This adds them with `aria-labelledby` and a corresponding id.
owi92
force-pushed
the
accessibile-copy-labels
branch
from
45dff7e
to
b73fb72
Compare
LukasKalbertodt
requested changes
Apr 11, 2023
LukasKalbertodt
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.
Fixes #659