Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve player link description for screen readers #771

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

owi92
Copy link
Member

@owi92 owi92 commented Apr 4, 2023

Previously, the alt tag was read, which doesn't convey the correct information for screen readers (somewhat implying that it links to the thumbnail, and not the video itself). Now it reads something like "Video page: {title}".

For now, this is only for the sidebox. We might want to consider doing a similar thing inside the series blocks, though there it's not as straightforward as with the sidebox link.
Also, "video" might not be the best term to use, as the events could be audio-only files. But we use "video" everywhere else, so if we use a different term, it should be updated everywhere, and I'm not sure which term would be best (probably something along the lines of "event", but that could also mean so many other things). I guess it's best to stick with "video" for now.

Fixes #661

@github-actions github-actions bot temporarily deployed to test-deployment-pr771 April 4, 2023 14:45 Destroyed
@owi92 owi92 added the area:accessibility Accessibility related issues label Apr 4, 2023
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some typography complaints :P

We might want to consider doing a similar thing inside the series blocks, though there it's not as straightforward as with the sidebox link.

Why is it not as easy there?
(If we don't use this translation string anywhere else, it should probably live in the "manage single video" scope instead.)

"Video" as term is fine I think.

frontend/src/i18n/locales/de.yaml Outdated Show resolved Hide resolved
frontend/src/i18n/locales/en.yaml Outdated Show resolved Hide resolved
Previously, the `alt` tag was read, which doesn't convey
the correct information for screen readers (somewhat implying
that it links to the thumbnail, and not the video itself).
Now it reads something like "Video page: {title}".
@github-actions github-actions bot temporarily deployed to test-deployment-pr771 April 12, 2023 12:56 Destroyed
@LukasKalbertodt LukasKalbertodt merged commit ac5576b into elan-ev:master Apr 12, 2023
2 checks passed
@owi92
Copy link
Member Author

owi92 commented Apr 12, 2023

We might want to consider doing a similar thing inside the series blocks, though there it's not as straightforward as with the sidebox link.

Why is it not as easy there?

Well it's not necessarily hard, but there are some additional things to consider:

  • Right now, the play time is also read by screen readers. This is important information, but it's read as "4 Uhr 57" in german which does not seem optimal.
  • The title beneath the thumbnail is read as well, so there is some repeated information.
  • And of course the name of the uploader is also read, but without context and without pause. So this would at least need to be preceded by something like "uploaded by..." for the screen-reader

We also show the thumbnails as links on the my videos page, which is important visual information but redundant as a link and description for screen-readers, since the video titles also act as those (though they would also need to say something like "video details of...". Maybe we can do that and then skip the thumbnail for keyboard and screen-readers in this case.

(If we don't use this translation string anywhere else, it should probably live in the "manage single video" scope instead.)

I don't think that is an existent scope, is it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:accessibility Accessibility related issues changelog:user User facing changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility of player link on video details
2 participants