Add space below h1 #785
Merged
Add space below h1 #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I saw that Bern university added an empty text block as first block to get more distance between the header and the first real text. In their version (1.4) the distance was 12px due to the `h1:first-child`. However, this `first-child` thing was not used anymore at all because of multiple things (wrapper divs inside Root or having breadcrumbs first). So I removed that. But I further increased the space from 16 to 20 because I think it looks better, certainly for realms. Most non-realm pages are not changed by this as they often have an element with a larger margin-top below the h1. Some pages are changed, but only slightly and it's still fine.
Due to the use of flexbox, there was an extra unnecessary 16px space above and below the heading.
owi92
approved these changes
Apr 17, 2023
| @@ -99,7 +99,7 @@ const ManageVideos: React.FC<Props> = ({ connection, vars }) => { | |||
| } else { | |||
| inner = <> | |||
| <PageNavigation {...{ vars, connection }} /> | |||
| <div css={{ flex: "1 0 0" }}> | |||
| <div css={{ flex: "1 0 0", margin: "16px 0" }}> | |||
There was a problem hiding this comment.
I made exactly the same changes to this file in #778 🤨
There was a problem hiding this comment.
Interesting how this doesn't result in a merge conflict or something ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits.