Fix audio-only playablility #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasKalbertodt
requested changes
May 2, 2023
There was a problem hiding this comment.
Just a tiny thing.
As you said, in the future we should do more to make the player page nice (show image in player area, ideally waveform, and probably reduce height of player). But that doesn't need to be now. To at least being able to play the audio is an improvement.
owi92
force-pushed
the
fix-audio-only-playability
branch
from
f5712cb
to
8173e25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically (sort of) reverts #506 since the handling of audio tracks appears to be working now.
There is also a paella plugin for audio-videos, but it doesn't appear to be necessary for this to work (https://github.com/polimediaupv/paella-core/blob/main/doc/audio_video_plugin.md, https://github.com/polimediaupv/paella-core/blob/main/doc/audio_canvas_plugin.md).
I'm also not certain if we should add some audio specific configuration for this in our
paella-coreandpaellafiles, as it also works without.One thing that is still not too pretty is the background of the audio-video, which is plain grey. It would be nice to show a more fitting preview image in the future (likely the one that is shown in series blocks, which would theoretically also be used as a video background, if I understand the docs correctly).
Fixes #795