Enable backtraces for errors #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owi92
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #752
In case you wanna test, just add a
bail!("Oopsie Woopsie");toConfig::validateand runcargo run -- check.Curiously, it takes a significant time to print the backtrace! This is very likely due to symbol resolution (when the backtrace is captured, only function addresses are captured, which later need to be resolved to function names and file locations). But I didn't expect it to be that bad. It should be better in release mode though. And I don't think this is problematic in practice. Errors reaching
mainare not expected and stop Tobira, so it's not a DOS vector.