Add redirect from video routes to direct video routes if realm does not exist #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot exist The idea is to reduce the need for handing out direct links. Before, "video with page context" links didn't work anymore if the page didn't exist or didn't include that video. To avoid these breaking links, users were asked to instead hand out direct links, which wouldn't break but also didn't have the page context/navigation. But we can just make the "page context link" do both. In case the page doesn't exist, it just forwards to the direct link. In the future we might want to show a note or something, but this is fine for now.
|
I'm quite skeptical that this (a link to a "video in page context" falls back to the direct link, when a page no longer exists) is a good idea. For details, see: #743 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to reduce the need for handing out direct links. Before, "video with page context" links didn't work anymore if the page didn't exist or didn't include that video. To avoid these breaking links, users were asked to instead hand out direct links, which wouldn't break but also didn't have the page context/navigation. But we can just make the "page context link" do both. In case the page doesn't exist, it just forwards to the direct link.
In the future we might want to show a note or something, but this is fine for now.