Make JWT key optional by generating it on the fly if unspecified #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this should work? But anything I try to upload either fails or isn't added to Tobira. Though it's the same on the current deployment, so I don't think this has anything to do with this PR. Can you confirm this? Is this the issue that ETH is also having? |
This makes setting up Tobira easier as one doesn't have to deal with JWT at all until later, when one can actually test the uploader and such. While I first only did that for the initial setup phase, I think using the generated key is totally fine for most use cases. Yes it changes, but rotating keys is actually something that's recommended anyway. And while Opencast has a cache on the JWKS data, if a JWT fails to validate, it purges the cache and tries again. So restarting Tobira does not cause any problems.
The required PG version was bumped to 11 a while ago.
LukasKalbertodt
force-pushed
the
jwt-optional
branch
from
c0d1081
to
4d74535
Compare
|
Our test deployments have a specific key specified. We have to as all test deployments have to use the same key so that they all can be used to upload to the same Opencast. So to properly test this, one needs to run a local Opencast and edit the Tobira config to not specify a key anymore. |
owi92
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.
Fixes #634