Fix tooltips not opening on mobile #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As tooltips on mobile are triggered via a click and we also close tooltips on click, this needs to check if the tooltip is actually open before it gets closed.
|
This still doesn't work on iOS :/ If it works now on Android browsers, we can still merge it. But yeah, would be great if it also worked on iOS. |
|
I does work on android. Really no idea why it doesn't on iOS :( |
|
Tested on browserstack android and it does indeed work. I edited your top comment so that merging doesn't close the linked issue yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #835
As tooltips on mobile are triggered via a click and we also close tooltips on click, this needs to check if the tooltip is actually open before it gets closed.
This still isn't perfect as if a user wants to open a tooltip again after closing it, they first need to click outside the trigger before it can be opened again. But I also think that's pretty much default behaviour.