Use shared ESLint config #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owi92
approved these changes
Jun 15, 2023
| @@ -257,7 +257,7 @@ export const makeRouter = <C extends Config, >(config: C): RouterLib => { | |||
| // When navigating to new routes, the scroll position always | |||
| // starts as 0 (i.e. the very top). | |||
| context.setActiveRoute({ route: newRoute, initialScroll: 0 }); | |||
| replaceEntry ? replace(href) : push(href); | |||
| (replaceEntry ? replace : push)(href); | |||
There was a problem hiding this comment.
Cool, didn't know this was possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed a lot of ESLint duplication (and maybe even worse: differences) between our three very similar-tech-stack projects Editor, Studio and Tobira. So we pulled out most of the config into a separate package.
This required minimal changes in Tobira, as we already had a pretty strict config.